make fit_freq work when df_master=None#7
Merged
Conversation
Closed
that the future warnings would go away.
Collaborator
|
@Simarilius-uk - Thank you for bringing this to my attention and putting the PR together. I'll merge it into the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fit function in prony.py defaults df_master to None and then calls fit_freq, which trys to access it and gets a cant subscript Nonetype error. The last change took the if opt clause out, this basically puts it back with the current method inside the if opt, and the old method in the else.
No idea if theres a better way to do it, and feel free to change the approach, but it gets the verify_freq_master.ipynb notebook to run without errors.
Appreciate the library, great resource to have.